diff options
author | Lars Hjemli <hjemli@gmail.com> | 2007-01-16 18:41:01 +0100 |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-01-16 18:41:01 +0100 |
commit | 66091f934a2d064ae55095cdc5ae008b43ea60fe (patch) | |
tree | 3faeafcfff2b21313464d9b919cd4b76b12a5fe9 /parsing.c | |
parent | 5cd2bf7e7f3f3daf6107cd3a269bad78e342de70 (diff) |
Handle empty/malformed commit messages
An empty commit message would trigger a segfault in the current
cgit_parse_commit().
Also, make sure that all char-pointers are properly initialized.
Diffstat (limited to 'parsing.c')
-rw-r--r-- | parsing.c | 19 |
1 files changed, 13 insertions, 6 deletions
@@ -145,6 +145,12 @@ struct commitinfo *cgit_parse_commit(struct commit *commit) ret = xmalloc(sizeof(*ret)); ret->commit = commit; + ret->author = NULL; + ret->author_email = NULL; + ret->committer = NULL; + ret->committer_email = NULL; + ret->subject = NULL; + ret->msg = NULL; if (strncmp(p, "tree ", 5)) die("Bad commit: %s", sha1_to_hex(commit->object.sha1)); @@ -180,12 +186,13 @@ struct commitinfo *cgit_parse_commit(struct commit *commit) p = strchr(p, '\n') + 1; t = strchr(p, '\n'); - ret->subject = substr(p, t); - p = t + 1; - - while (*p == '\n') - p = strchr(p, '\n') + 1; - ret->msg = p; + if (t && *t) { + ret->subject = substr(p, t); + p = t + 1; + while (*p == '\n') + p = strchr(p, '\n') + 1; + ret->msg = p; + } return ret; } |