summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-09-06ui-plain.c: only return the blob with the specified pathLars Hjemli
When a path to a directory was specified for the 'plain' view, each blob in the directory used to be returned to the client. This patch fixes the issue by matching the path of each blob against the requested path. Noticed-by: Lars Stoltenow <penma@penma.de> Signed-off-by: Lars Hjemli <larsh@slackbox.hjemli.net>
2009-08-18truncate buffer before reading empty filesSimon Arlott
If readfile() reads an empty file, fgets() won't truncate the buffer and it'll still contain the contents of the previously read file. [lh: fixed similar issue in ui-repolist.c] Signed-off-by: Simon Arlott <simon@fire.lp0.eu> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-08-18ui-shared: don't print header <img/> if there isn't a logo definedMatthew Metnetsky
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-08-17cgit.c: do not segfault on unexpected query-string formatLars Hjemli
The querystring_cb() function will be invoked with a NULL value when the querystring contains a name not followed by a '='. Such a value used to cause a segfault, which this patch fixes. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-08-17ui-tag.c: do not segfault when id is missing from query-stringLars Hjemli
The purpose of the tag page is to print info about a specific tag, but if no tag was specified on the query-string cgit used to segfault. With this patch, cgit will fallback to the value of the 'h' parameter instead (which is never NULL due to prepare_repo_cmd() in cgit.c). It will now also verify that the specified tagname is in fact a valid ref in the 'refs/tags/' namespace, i.e. specifying 'id=master' will trigger a 'Bad tag reference' error. Noticed-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-03-15CGIT 0.8.2.1v0.8.2.1Lars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-03-15ui-snapshot: avoid segfault when no filename is specifiedLars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-03-15fix segfault when displaying empty blobsEric Wong
When size is zero, subtracting one from it turns it into ULONG_MAX which causes an out-of-bounds access on buf. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-02-12ui-tree: escape ascii-text properly in hexdump viewLars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-02-01CGIT 0.8.2v0.8.2Lars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-02-01Use GIT-1.6.1.1Lars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-02-01Merge branch 'lh/binary'Lars Hjemli
2009-02-01shared.c: avoid SEGFAULT when checking for binary buffersLars Hjemli
Before calling buffer_is_binary() we need to verify that the buffer is valid. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-02-01Merge branch 'lh/header'Lars Hjemli
2009-01-31ui-tree: show hexdump of binary blobsLars Hjemli
This teaches ui-tree to detect binary blobs and display them similar to `hexdump -C` (only wider). Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-31Handle binary files in diffsLars Hjemli
This teaches all diff-related operations (i.e. ui-log, ui-diff and ui-patch) how to handle binary files. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-29Merge branch 'stable'Lars Hjemli
2009-01-29html.c: use correct escaping in html attributesLars Hjemli
First, an apostrophe is not a quote. Second, we also need to escape quotes. And finally, quotes are encoded as '&quot;', not '&quote;'. Sighned-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-29Add support for a custom headerLars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-27Merge branch 'stable'Lars Hjemli
2009-01-27Merge branch 'jw/commit-decorations'Lars Hjemli
Conflicts: cgit.css Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-27tests/t0105-commit.sh: expect commit decorationsLars Hjemli
When a commit is referenced by a branch or tag the commit subject- line will be suffixed with the proper decorations, hence the test for this line needs to be updated. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-27cgit.css: minor adjustment of commit decorationsLars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-27Add decorations to commit pagesJustin Waters
This adds the tag and branch head decorations to the commit pages. This is similar to how commits are displayed in the standard gitweb interface. Signed-off-by: Justin Waters <justin.waters@timesys.com>
2009-01-27CGIT 0.8.1.1v0.8.1.1Lars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-27Merge branch 'og/tree-view-selection'Lars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-27Merge branch 'lh/stats'Lars Hjemli
Conflicts: cgit.c cgit.css cgit.h ui-tree.c Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-12Merge branch 'stable'Lars Hjemli
2009-01-12Makefile: install cgit.{css,png} in CGIT_DATA_PATHTodd Zullinger
CGIT_DATA_PATH defaults to CGIT_SCRIPT_PATH, but allows users to install the cgi and the data files in different locations. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-12Makefile: add INSTALL var to set install commandTodd Zullinger
This also explicitly sets the modes for installed files (755 for the .cgi, 644 for the .css and .png). Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-12Fix tar.bz2 snapshot exampleTodd Zullinger
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-11Merge branch 'stable'Lars Hjemli
2009-01-11Avoid SEGFAULT on invalid requestsLars Hjemli
When an unknown page is requested, either on the querystring or via PATH_INFO, we end up with a null-referencing cgit_cmd. This null- pointer is then used as argument to the hc() function (which decides what tab to render as 'active'), but this function failed to check if a valid cmd was specified and a SEGFAULT would occur. This patch fixes the issue by introducing a 'fallback-cmd' which specifies what tab to render as 'active' when no valid cmd is requested. While at it, we now also keep track of the active repository even if an invalid cmd was requested since we want to show the error message about the invalid request in the correct context. Noticed-by: Robin Redeker <elmex@ta-sa.org> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-11Make all tags viewableRobin Redeker
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-11Merge branch 'stable'Lars Hjemli
2009-01-11ui-tag: escape tagnames properlyLars Hjemli
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-11Change toggle to more meaningful termJustin Waters
In the log interface, there is a toggle link at the top, but it isn't clear what's being toggled. I've changed it to "Expand" and "Collapse" to make it clear that you are getting more and less information, respectively. Signed-off-by: Justin Waters <justin.waters@timesys.com>
2009-01-11Merge branch 'snapshot-fixes'Lars Hjemli
2009-01-11Merge branch 'lh/mimetypes'Lars Hjemli
2009-01-11Merge branch 'lh/virtual-root'Lars Hjemli
2009-01-11Merge branch 'stable'Lars Hjemli
2009-01-11ui-log: show name-decorations in log outputLars Hjemli
Commits are now decorated with a clickable 'label' for each ref pointing at it, similar to how gitweb and gitk displays commit decorations. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-10Makefile: avoid libcurl when building gitLars Hjemli
We don't need support for fetching/pushing in libgit.a, hence we don't need to link with libcurl. Noticed-by: Robin Redeker <elmex@ta-sa.org> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-10ui-refs: avoid SEGFAULT on lightweight tagsRobin Redeker
Signed-off-by: Robin Redeker <elmex@ta-sa.org> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2009-01-10changed objects are outputted, allowing for selections of code onlyOnne Gorter
2009-01-06Merge branch 'stable'Lars Hjemli
2009-01-06ui-tree.c: do not add blank line when displaying blobsLars Hjemli
Also, fix a related bug in the test-suite. Noticed-by: Jim Meyering <jim@meyering.net> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2008-12-30Merge branch 'stable'Lars Hjemli
2008-12-30ui-patch: whitespace changes in the patch generation codeTomas Carnecky
Add a space between the committer name and email, and remove superfluous spaces in the date header. This makes cgit-generated patches match the output from git-format-patch almost exactly, at least as far as the email headers go. Signed-off-by: Tomas Carnecky <tom@dbservice.com> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
2008-12-28tests/t0107-snapshot.sh: make testscript match updated snapshot behaviorLars Hjemli
Since cgit now returns a 404 error when the snapshot filename cannot be resolved to a commit object, the testscript needs to request a valid snapshot name. Also, the script assumed that the toplevel directory in the snapshot would get the name of the repository but it's now named similar to the requested snapshot. Signed-off-by: Lars Hjemli <hjemli@gmail.com>